Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfml 3.0.0 #202104

Merged
merged 8 commits into from
Dec 25, 2024
Merged

sfml 3.0.0 #202104

merged 8 commits into from
Dec 25, 2024
+109 −32

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 22, 2024
@alebcay alebcay added the build failure CI fails while building the software label Dec 22, 2024
@daeho-ro daeho-ro force-pushed the bump-sfml-3.0.0 branch 3 times, most recently from c2f32ec to d4c74c9 Compare December 22, 2024 05:25
@iMichka
Copy link
Member

iMichka commented Dec 23, 2024

CMake Error at /opt/homebrew/Library/Homebrew/cmake/trap_fetchcontent_provider.cmake:12 (message):
Refusing to populate dependency 'Freetype' with FetchContent while building
in Homebrew, please use a formula dependency or add a resource to the
formula.
Call Stack (most recent call first):
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468:EVAL:1 (trap_fetchcontent_provider)
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468 (cmake_language)
/opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2314 (__FetchContent_MakeAvailable_eval_code)
src/SFML/Graphics/CMakeLists.txt:137 (FetchContent_MakeAvailable)
src/SFML/Graphics/CMakeLists.txt:153 (sfml_add_graphics_dependencies)

@iMichka iMichka force-pushed the bump-sfml-3.0.0 branch 2 times, most recently from e370767 to 59bf54e Compare December 23, 2024 22:25
@iMichka iMichka removed the build failure CI fails while building the software label Dec 23, 2024
@iMichka iMichka requested a review from chenrui333 December 23, 2024 22:35
@iMichka iMichka added the ready to merge PR can be merged once CI is green label Dec 23, 2024
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed ready to merge PR can be merged once CI is green labels Dec 24, 2024
@ChrisThrasher
Copy link
Contributor

ChrisThrasher commented Dec 24, 2024 •
edited
Loading

CMake Error at /opt/homebrew/Library/Homebrew/cmake/trap_fetchcontent_provider.cmake:12 (message): Refusing to populate dependency 'Freetype' with FetchContent while building in Homebrew, please use a formula dependency or add a resource to the formula. Call Stack (most recent call first): /opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468:EVAL:1 (trap_fetchcontent_provider) /opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2468 (cmake_language) /opt/homebrew/opt/cmake/share/cmake/Modules/FetchContent.cmake:2314 (__FetchContent_MakeAvailable_eval_code) src/SFML/Graphics/CMakeLists.txt:137 (FetchContent_MakeAvailable) src/SFML/Graphics/CMakeLists.txt:153 (sfml_add_graphics_dependencies)

SFML maintainer here! You can set SFML_USE_SYSTEM_DEPS to ON to bypass all this FetchContent stuff and fall back to find_package.

EDIT: I see this is already being used 👍🏻

@chenrui333
Copy link
Member

chenrui333 commented Dec 24, 2024 •
edited
Loading

yeah, now we just need downstream API compatible patches.

@ChrisThrasher any chance to make a release for csfml to work with sfml v3?

saw the milestone tracker on it, https://github.com/SFML/CSFML/milestone/1

@chenrui333 chenrui333 mentioned this pull request Dec 24, 2024
Open
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 24, 2024
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed in progress Stale bot should stay away labels Dec 24, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 24, 2024
@ChrisThrasher
Copy link
Contributor

yeah, now we just need downstream API compatible patches.

@ChrisThrasher any chance to make a release for csfml to work with sfml v3?

saw the milestone tracker on it, https://github.com/SFML/CSFML/milestone/1

CSFML 3 is mostly ready to ship. The master branch of its repo compiles with SFML 3.0.0. I hope to ship CSFML 3 in January 2025.

@chenrui333
Copy link
Member

yeah, now we just need downstream API compatible patches.
@ChrisThrasher any chance to make a release for csfml to work with sfml v3?
saw the milestone tracker on it, https://github.com/SFML/CSFML/milestone/1

CSFML 3 is mostly ready to ship. The master branch of its repo compiles with SFML 3.0.0. I hope to ship CSFML 3 in January 2025.

sounds good 👍

@BrewTestBot @chenrui333 @iMichka
sfml 3.0.0
5a13665 
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: Michka Popoff <[email protected]>
@chenrui333
sfml@2 2.6.2 (new formula)
558ea35 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333
csfml: revision bump (sfml 3.0.0)
7375049 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333
tgui: revision bump (sfml 3.0.0)
e900059 
tgui: update test

```
  ==> ./test
  ./test: error while loading shared libraries: libsfml-graphics.so.2.6: cannot open shared object file: No such file or directory
  Error: tgui: failed
  An exception occurred within a child process:
    BuildError: Failed executing: ./test
```

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 25, 2024
Merged via the queue into master with commit aba028e Dec 25, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-sfml-3.0.0 branch December 25, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BrewTestBot @iMichka @ChrisThrasher @chenrui333 @daeho-ro @alebcay